fix: update go-diff package #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @ffluk3, this version bump doesn't seem to contain to the fix here sergi/go-diff#136 since a new tag hasn't been cut since it was merged. |
|
Ah I see. So the original issue was fixed: sergi/go-diff#89. However, there was a small reported regression as a result of the fix. CLRF files seem to have issue still and the version needs to be bumped for that. |
Resolves launchdarkly#351, where the tool would throw index out of range errors for sufficiently large source code diffs. The downstream library was recently updated to allow for significantly larger diff max sizes, as discussed in the associated issue.
ffluk3
force-pushed
the
update-go-diff
branch
from
0afc31a
to
a92bcc4
Compare
|
@jazanne I've updated this PR to use the commit hash-based version that folds in the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #351, where the tool would throw index out of range errors for sufficiently large source code diffs. The downstream library was recently updated to allow for significantly larger diff max sizes, as discussed in the associated issue.