Skip to content

feat: Allow imports from paths. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 6 commits into from
Jun 15, 2023
Merged

feat: Allow imports from paths. #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee147c8
Add integrations file.
kinyoklion Jun 13, 2023
4b4dfbc
Update format.
kinyoklion Jun 13, 2023
db1a463
Exports and types.
kinyoklion Jun 13, 2023
5810350
lint
kinyoklion Jun 13, 2023
af59f8b
Fix lint command.
kinyoklion Jun 13, 2023
d1e62f9
Merge branch 'main' into rlamb/exports-paths
kinyoklion Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/sdk/server-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@
"type": "commonjs",
"main": "./dist/src/index.js",
"types": "./dist/src/index.d.ts",
"exports": {
Copy link
Member Author

@kinyoklion kinyoklion Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make everything happy. I tried require and import in JS with node, and I tried import in TS with node. Everything worked and showed types. I needed the "typesVersions" before vscode intellisense worked correctly for integrations.

I have not done this much, so I am not a domain expert here.

import { TestData } from '@launchdarkly/node-server-sdk/integrations';

I am still exporting integrations from the main package. Probably safe for now.

".": {
"default": "./dist/src/index.js",
"types": "./dist/src/index.d.ts"
},
"./integrations": {
"default": "./dist/src/integrations.js",
"types": "./dist/src/integrations.d.ts"
}
},
"typesVersions": {
"*": {
"integrations": ["./dist/src/integrations.d.ts"]
}
},
"files": [
"dist"
],
Expand All @@ -25,7 +40,7 @@
"test": "npx jest --ci --runInBand",
"build": "npx tsc",
"lint": "npx eslint . --ext .ts",
"lint:fix": "yarn run lint -- --fix"
"lint:fix": "yarn run lint --fix"
},
"license": "Apache-2.0",
"dependencies": {
Expand Down
5 changes: 5 additions & 0 deletions packages/sdk/server-node/src/integrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { integrations } from '@launchdarkly/js-server-sdk-common';

const { FileDataSourceFactory, TestData, TestDataFlagBuilder, TestDataRuleBuilder } = integrations;

export { FileDataSourceFactory, TestData, TestDataFlagBuilder, TestDataRuleBuilder };