Skip to content

fix: browser logging for non-existing flags #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker23 merged 1 commit into from
Jan 8, 2026
Merged

fix: browser logging for non-existing flags #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/shared/sdk-client/__tests__/LDClientImpl.variation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,21 @@ describe('sdk-client object', () => {
expect(devTestFlag).toBe(true);
});

test('variation flag not found', async () => {
test('variation flag not found should give a warning message', async () => {
await ldc.identify({ kind: 'user', key: 'test-user' });
const errorListener = jest.fn().mockName('errorListener');
ldc.on('error', errorListener);

const p = ldc.identify(context);
ldc.variation('does-not-exist', 'not-found');
const flagValue = ldc.variation('does-not-exist', 'not-found');

await expect(p).resolves.toBeUndefined();
expect(errorListener).toHaveBeenCalledTimes(1);
const error = errorListener.mock.calls[0][1];
expect(error.message).toMatch(/unknown feature/i);

expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('Unknown feature'));
expect(flagValue).toBe('not-found');
});

test('variationDetail flag not found', async () => {
test('variationDetail flag not found should return an error detail', async () => {
await ldc.identify(context);
const flag = ldc.variationDetail('does-not-exist', 'not-found');

Expand Down
6 changes: 2 additions & 4 deletions packages/shared/sdk-client/src/LDClientImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,11 +543,9 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {

if (foundItem === undefined || foundItem.flag.deleted) {
const defVal = defaultValue ?? null;
const error = new LDClientError(
`Unknown feature flag "${flagKey}"; returning default value ${defVal}.`,
);

this.emitter.emit('error', this._activeContextTracker.getUnwrappedContext(), error);
this.logger?.warn(`Unknown feature flag "${flagKey}"; returning default value ${defVal}.`);

if (hasContext) {
this._eventProcessor?.sendEvent(
this._eventFactoryDefault.unknownFlagEvent(flagKey, defVal, evalContext),
Expand Down