feat: Allow imports from paths. #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/exports-paths
branch
from
b6b5e5f to
4b4dfbc
Compare
kinyoklion
commented
Jun 13, 2023
| "type": "commonjs", | ||
| "main": "./dist/src/index.js", | ||
| "types": "./dist/src/index.d.ts", | ||
| "exports": { |
Member
Author
There was a problem hiding this comment.
This seems to make everything happy. I tried require and import in JS with node, and I tried import in TS with node. Everything worked and showed types. I needed the "typesVersions" before vscode intellisense worked correctly for integrations.
I have not done this much, so I am not a domain expert here.
import { TestData } from '@launchdarkly/node-server-sdk/integrations';
I am still exporting integrations from the main package. Probably safe for now.
kinyoklion
changed the title
yusinto
approved these changes
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.