Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 compatibility issue due to startsWith #168

Closed
cvetanov opened this issue Jul 29, 2019 · 2 comments
Closed

IE 11 compatibility issue due to startsWith #168

cvetanov opened this issue Jul 29, 2019 · 2 comments

Comments

@cvetanov
Copy link
Contributor

cvetanov commented Jul 29, 2019

Describe the bug
Application does not work in IE due to not supported method startsWith.

To reproduce
Any React application trying to use the launchdarkly-react-client-sdk package.

Expected behavior
Should work in IE since the docs do not mention adding a polyfill for String.prototype.startsWith and seems like it was fixed in a previous version of the client SDK

Current workaround
Adding a polyfill for String.prototype.startsWith ourselves.

Logs
Object doesn't support property or method 'startsWith'

SDK version
"launchdarkly-react-client-sdk": "^2.12.4"

Language version, developer tools
Not sure if relevant, but we are on React v16.8.6

OS/platform
Browser IE 11

Additional context
Most probably caused by the condition in here.

@eli-darkly
Copy link
Contributor

Thanks for catching this! We'll have a patch out shortly.

@eli-darkly
Copy link
Contributor

Fixed in the 2.12.5 release.

LaunchDarklyCI pushed a commit that referenced this issue Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants