fix(world): resolve system namespace label (#3232)

Co-authored-by: Kevin Ingersoll <[email protected]>
latticexyz · Sep 25, 2024 · 9d7fc85 · 9d7fc85
1 parent 98f937c
commit 9d7fc85
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/heavy-donkeys-move.md b/.changeset/heavy-donkeys-move.md
@@ -0,0 +1,6 @@
+---
+"@latticexyz/world": patch
+---
+
+The `namespace` field in a multi-namespace config is now correctly resolved for systems.
+This fixes a bug with root systems in a multi-namespace project.
diff --git a/packages/world/ts/node/buildSystemsManifest.ts b/packages/world/ts/node/buildSystemsManifest.ts
@@ -59,7 +59,11 @@ export async function buildSystemsManifest(opts: { rootDir: string; config: Worl
       const artifact = getSystemArtifact(system);
       const abi = artifact.abi.filter((item) => !excludedAbi.includes(formatAbiItem(item)));
       const worldAbi = system.deploy.registerWorldFunctions
-        ? abi.map((item) => (item.type === "function" ? { ...item, name: `${system.namespace}__${item.name}` } : item))
+        ? abi.map((item) =>
+            item.type === "function"
+              ? { ...item, name: system.namespace ? `${system.namespace}__${item.name}` : item.name }
+              : item,
+          )
         : [];
       return {
         // labels

diff --git a/packages/world/ts/node/resolveSystems.ts b/packages/world/ts/node/resolveSystems.ts
@@ -31,9 +31,10 @@ export async function resolveSystems({
   const systems = systemContracts
     .map((contract): ResolvedSystem => {
       const systemConfig =
-        config.namespaces[contract.namespaceLabel].systems[contract.systemLabel] ??
+        config.namespaces[contract.namespaceLabel]?.systems[contract.systemLabel] ??
         resolveNamespace({
           label: contract.namespaceLabel,
+          namespace: config.namespaces[contract.namespaceLabel]?.namespace,
           systems: {
             [contract.systemLabel]: {},
           },