Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unknown engine(s) when saving #350

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

muzimuzhi
Copy link
Contributor

This PR solves a l3build save problem that unknown engines passed to -e|--engine are not skipped.

Run texlua ./l3build.lua save -epdftex,XXX 00-test-1 in this repository,

  • Before

    Although Skipping unknown engine XXX is printed, unknown engine XXX is not skipped hence the problem sh: XXX: command not found.

    $ texlua ./l3build.lua save -epdftex,XXX 00-test-1
    Skipping unknown engine XXX
    This is pdfTeX, ...
    ...
    Transcript written on 00-test-1.log.
    Creating and copying 00-test-1.XXX.tlg
    sh: XXX: command not found
    ./l3build-check.lua:97: ./build/test/00-test-1.log: No such file or directory
    
  • After, unknown engine is correctly skipped.

    $ texlua ./l3build.lua save -epdftex,XXX 00-test-1
    Skipping unknown engine XXX
    This is pdfTeX, ...
    ...
    Transcript written on 00-test-1.log.
    

@josephwright josephwright merged commit f976c43 into latex3:main Feb 29, 2024
1 check failed
@muzimuzhi muzimuzhi deleted the fix/save-sanitized-engines branch February 29, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants