Drop switch --force|-f #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muzimuzhi Would welcome your thoughts here (I can't directly add you as a reviewer). |
|
@FrankMittelbach This the sort of change you had in mind? |
Unknown engines are then skipped with a message, rather than leading to an error.
josephwright
force-pushed
the
drop-force
branch
from
b489934
to
026dca5
Compare
FrankMittelbach
approved these changes
Jan 18, 2024
| end | ||
| end | ||
| end | ||
| if not next(checkengines) then exit(0) end |
There was a problem hiding this comment.
not sure it helps or not, but perhaps add a print("No applicable engine requested, config ignored")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown engines are then skipped with a message, rather than leading to an error.