Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional GSSAPI auth for Custodia client #238

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Optional GSSAPI auth for Custodia client #238

merged 2 commits into from
Jan 17, 2018

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 11, 2018

PR based on #235

adelton and others added 2 commits January 10, 2018 23:38
@adelton @tiran
Add support for GSSAPI authentication.
ef26cb8
@tiran
Update GSSAPI code
1086d5b 
- Make dependency on requests_gssapi optional
- Add requests_gssapi to setup.py
- Add simple test case
- Move auth options to mutually exclusive groups

Signed-off-by: Christian Heimes <[email protected]>
@codecov-io
Copy link

codecov-io commented Jan 11, 2018 •
edited
Loading

Codecov Report

Merging #238 into master will decrease coverage by 0.08%.
The diff coverage is 61.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #238      +/-   ##
=========================================
- Coverage   72.79%   72.7%   -0.09%     
=========================================
  Files          41      41              
  Lines        4440    4470      +30     
  Branches      449     454       +5     
=========================================
+ Hits         3232    3250      +18     
- Misses       1052    1063      +11     
- Partials      156     157       +1
Impacted Files Coverage Δ
tests/test_custodia.py 95.2% <100%> (+0.17%) ⬆️
src/custodia/cli/__init__.py 44.32% <40%> (-1.08%) ⬇️
src/custodia/client.py 79.14% <50%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511bf2a...1086d5b. Read the comment docs.

@tiran
Copy link
Member Author

tiran commented Jan 11, 2018

Travis CI is currently broken:

$ sudo apt-get -qq update
W: GPG error: http://repo.mongodb.org/apt/ubuntu trusty/mongodb-org/3.4 Release: The following signatures were invalid: KEYEXPIRED 1515625755
W: The repository 'http://repo.mongodb.org/apt/ubuntu trusty/mongodb-org/3.4 Release' is not signed.
W: http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/Release.gpg: Signature by key 15866BAFD9BCC4F3C1E0DFC7D69548E1C17EAB57 uses weak digest algorithm (SHA1)
E: Failed to fetch store:/var/lib/apt/lists/partial/repo.mongodb.org_apt_ubuntu_dists_trusty_mongodb-org_3.4_multiverse_binary-i386_Packages  Empty files can't be valid archives
E: Some index files failed to download. They have been ignored, or old ones used instead.
``

@tiran tiran mentioned this pull request Jan 11, 2018
Open
@tiran tiran requested review from raildo and simo5 January 17, 2018 10:56
raildo
raildo approved these changes Jan 17, 2018
View reviewed changes
Copy link

@raildo raildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiran
Copy link
Member Author

tiran commented Jan 17, 2018

@adelton please test and confirm this PR

simo5
simo5 approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tiran
Copy link
Member Author

tiran commented Jan 17, 2018

thx

I'll merge the PR as soon as @adelton has confirmed that it's working for him.

@adelton adelton mentioned this pull request Jan 17, 2018
Closed
@adelton
Copy link
Contributor

adelton commented Jan 17, 2018

I've backported the patch to 0.5 to test on my 0.5 setup, I tried it both with --gssapi and without it on machine where I've forcibly removed python-requests-gssapi, things look good. Thank you for making it optional.

@tiran tiran merged commit 95967d3 into latchset:master Jan 17, 2018
@tiran tiran deleted the gssapi branch January 17, 2018 17:00
@tiran
Copy link
Member Author

tiran commented Jan 17, 2018

thx for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

@raildo raildo raildo approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @codecov-io @adelton @raildo @simo5