feat: add reproducible Meticulous recording suite - #31
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds Meticulous recording infrastructure, dedicated Playwright journeys, PWA shortcut coverage, synchronous shortcut startup, CI gating, and recording workflow documentation. ChangesMeticulous recording and E2E coverage
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant RecordingSuite as Playwright recording suite
participant App as Coffee Timer app
participant Recorder as Meticulous recorder
participant TestInfo as Playwright TestInfo
RecordingSuite->>App: Open journey with recording query
App->>Recorder: Expose window.Meticulous.record
RecordingSuite->>App: Execute user flow
RecordingSuite->>Recorder: Read session URL and flush events
Recorder-->>TestInfo: Attach session URL
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/meticulous.yml:
- Around line 20-23: Replace github.actor with
github.event.pull_request.user.login in the Dependabot skip gate in
.github/workflows/meticulous.yml lines 20-23 and the corresponding documented
example in docs/meticulous.md lines 163-166, preserving the existing conditions
and behavior.
In `@e2e/pwa-shortcuts.spec.ts`:
- Line 8: Update the shortcut navigation steps in the PWA shortcut tests to open
the actual /shortcuts/settings and /shortcuts/start endpoints instead of
directly using the query-string action route. Keep the existing post-redirect UI
assertions unchanged so the tests validate both shortcut routing and resulting
screens.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 24a32938-6e36-4b09-bead-5207656d4c5d
📒 Files selected for processing (11)
.github/workflows/meticulous.ymlapp/[locale]/page.tsxdocs/meticulous.mde2e/meticulous/constants.tse2e/meticulous/meticulous-window.d.tse2e/meticulous/recording-helpers.tse2e/meticulous/recording.spec.tse2e/pwa-shortcuts.spec.tspackage.jsonplaywright.config.tsplaywright.meticulous.config.ts
|
✅ Meticulous spotted 0 visual differences across 142 screens tested: view results. Meticulous evaluated ~2 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
- identify Dependabot pull requests by their author\n- exercise shortcut redirects without locale proxy interference
Summary
Recorded journeys
Verification
pnpm meticulous:record— 10/10 passed for the full suite; updated flows re-recorded after reviewpnpm lintpnpm typecheckpnpm buildpnpm exec playwright test e2e/pwa-shortcuts.spec.ts e2e/timer-behavior.spec.ts --project="Desktop Chrome"— 9 passed, 1 skippedMeticulous Dashboard: https://app.meticulous.ai/projects/laststance/coffee-timer?tab=selected-sessions
Summary by CodeRabbit