Skip to content

fix(web): keep annotation actions attached to dialog #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lastobelus merged 1 commit into from
Aug 23, 2026
Merged

fix(web): keep annotation actions attached to dialog #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions apps/web/src/components/thread-annotation/ThreadAnnotation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { scopedThreadKey } from "@t3tools/client-runtime/environment";
import {
useCallback,
useEffect,
useId,
useRef,
useState,
useSyncExternalStore,
Expand Down Expand Up @@ -81,6 +82,7 @@ export function ThreadAnnotationEditorDialog(props: {
}) {
const [body, setBody] = useState("");
const [saving, setSaving] = useState(false);
const formId = useId();
const textareaRef = useRef<HTMLTextAreaElement | null>(null);
const wasOpenRef = useRef(false);

Expand All @@ -105,14 +107,14 @@ export function ThreadAnnotationEditorDialog(props: {
return (
<Dialog open={props.open} onOpenChange={props.onOpenChange}>
<DialogPopup className="max-w-xl">
<form onSubmit={(event) => void submit(event)}>
<DialogHeader>
<DialogTitle>{props.annotation ? "Edit annotation" : "Annotate thread"}</DialogTitle>
<DialogDescription>
Markdown supports headings, lists, task lists, links, and tags.
</DialogDescription>
</DialogHeader>
<DialogPanel scrollFade={false}>
<DialogHeader>
<DialogTitle>{props.annotation ? "Edit annotation" : "Annotate thread"}</DialogTitle>
<DialogDescription>
Markdown supports headings, lists, task lists, links, and tags.
</DialogDescription>
</DialogHeader>
<DialogPanel scrollFade={false}>
<form id={formId} onSubmit={(event) => void submit(event)}>
<Textarea
ref={textareaRef}
aria-label="Thread annotation"
Expand All @@ -130,16 +132,16 @@ export function ThreadAnnotationEditorDialog(props: {
}
}}
/>
</DialogPanel>
<DialogFooter>
<Button type="button" variant="ghost" onClick={() => props.onOpenChange(false)}>
Cancel
</Button>
<Button disabled={!body.trim() || saving} type="submit">
{saving ? "Saving…" : props.annotation ? "Save" : "Add annotation"}
</Button>
</DialogFooter>
</form>
</form>
</DialogPanel>
<DialogFooter>
<Button type="button" variant="ghost" onClick={() => props.onOpenChange(false)}>
Cancel
</Button>
<Button disabled={!body.trim() || saving} form={formId} type="submit">
{saving ? "Saving…" : props.annotation ? "Save" : "Add annotation"}
</Button>
</DialogFooter>
</DialogPopup>
</Dialog>
);
Expand Down