Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editor] Image Output Rendering #744

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[editor] Image Output Rendering #744

merged 1 commit into from
Jan 3, 2024

Conversation

rholinshead
Copy link
Contributor

@rholinshead rholinshead commented Jan 3, 2024 •
edited
Loading

[editor] Image Output Rendering

Get image output rendering with the updated output types, handling both file_uri and base64 encoding.

Testing:

  • Tested both dall-e-2 and 3 models to ensure outputs render, toggle between uri/base64 and raw JSON:
Screen.Recording.2024-01-03.at.4.33.41.PM.mov
  • Made sure the gpt4-v input rendering still works with updated MimeTypeRenderer component:
Screenshot 2024-01-03 at 4 31 52 PM

@rholinshead rholinshead marked this pull request as ready for review January 3, 2024 21:41
saqadri
saqadri approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@saqadri saqadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

@rholinshead rholinshead merged commit 98dced1 into main Jan 3, 2024
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqadri saqadri saqadri approved these changes

@suyoglastmileai suyoglastmileai Awaiting requested review from suyoglastmileai

@Ankush-lastmile Ankush-lastmile Awaiting requested review from Ankush-lastmile Ankush-lastmile is a code owner

@jonathanlastmileai jonathanlastmileai Awaiting requested review from jonathanlastmileai jonathanlastmileai is a code owner

@rossdanlm rossdanlm Awaiting requested review from rossdanlm rossdanlm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rholinshead @saqadri