[vscode][ez] Override Mantine Menu/Dropdown Styles with VSCode Styles #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2024 19:48
# [vscode][ez] Fix Propt Input Focus Outline Colour Looks like this colour was missed when translating to vscode variables, so just use the same outline as other places. ## Before  ## After 
# [vscode][ez] Override Mantine Default Input Colors with VSCode Theme The default mantine input styles (background, color, focus outline, placeholder color) are ok in some cases but can be improved for all themes by using the appropriate theme variables. ## Before: https://github.com/lastmile-ai/aiconfig/assets/5060851/0efd596d-759e-4be6-b99c-01a1583d0ae0 ## After: https://github.com/lastmile-ai/aiconfig/assets/5060851/6baefd19-a3cf-491c-a2d4-12eae426087f
This was referenced Feb 8, 2024
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
# [vscode][ez] Override Mantine Menu/Dropdown Styles with VSCode Styles Update the menu and autoselect dropdowns to have correct theme styles. ## Before:   ## After:  
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vscode][ez] Override Mantine Menu/Dropdown Styles with VSCode Styles
[vscode][ez] Override Mantine Menu/Dropdown Styles with VSCode Styles
Update the menu and autoselect dropdowns to have correct theme styles.
Before:
After:
Stack created with Sapling. Best reviewed with ReviewStack.