Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python version >=3.10 is required, 3.9 receives error #1143

Closed
erdemunal35 opened this issue Feb 6, 2024 · 2 comments · Fixed by #1146
Closed

python version >=3.10 is required, 3.9 receives error #1143

erdemunal35 opened this issue Feb 6, 2024 · 2 comments · Fixed by #1146
Assignees
@rossdanlm

Comments

@erdemunal35
Copy link

Hi,
I receive the error below when the python version of the virtual environment I install aiconfig is 3.9
Screenshot 2024-02-06 at 08 46 50

when I use 3.10 it works fine. Can we say/add python version >=3.10 is required to the README.md?

Best,
Erdem
@saqadri
Copy link
Contributor

saqadri commented Feb 6, 2024

Thanks for reporting @erdemunal35! @Ankush-lastmile or @jonathanlastmileai can you PTAL?

rossdanlm pushed a commit that referenced this issue Feb 6, 2024
Changing all pyproject requires-python to 3.10
e12158e 
We have some libraries like `TypeAlias` that require Python 3.10, as flagged by #1143

We're just going to be consistent for all extensions (even the ones that don't use the 3.10 libraries).

I'm also going to re-publish the libraries (and includes this in the release notes!)
@rossdanlm rossdanlm mentioned this issue Feb 6, 2024
Merged
rossdanlm pushed a commit that referenced this issue Feb 6, 2024
Changing all pyproject requires-python to 3.10
0521980 
We have some libraries like `TypeAlias` that require Python 3.10, as flagged by #1143

We're just going to be consistent for all extensions (even the ones that don't use the 3.10 libraries).

I'm also going to re-publish and build the libraries (and includes this in the release notes!)
@rossdanlm rossdanlm self-assigned this Feb 6, 2024
@rossdanlm rossdanlm linked a pull request Feb 6, 2024 that will close this issue
Changing all pyproject requires-python to 3.10 #1146
Merged
rossdanlm pushed a commit that referenced this issue Feb 6, 2024
Changing all pyproject requires-python to 3.10
6533b2d 
We have some libraries like `TypeAlias` that require Python 3.10, as flagged by #1143

We're just going to be consistent for all extensions (even the ones that don't use the 3.10 libraries).

I'm also going to re-publish and build the libraries (and includes this in the release notes!)
rossdanlm pushed a commit that referenced this issue Feb 6, 2024
Changing all pyproject requires-python to 3.10
1b6124f 
We have some libraries like `TypeAlias` that require Python 3.10, as flagged by #1143

We're just going to be consistent for all extensions (even the ones that don't use the 3.10 libraries).

I'm also going to re-publish and build the libraries (and includes this in the release notes!)
rossdanlm added a commit that referenced this issue Feb 6, 2024
@rossdanlm
Changing all pyproject requires-python to 3.10 (#1146)
02a3e1c 
Changing all pyproject `requires-python` to 3.10

We have some libraries like `TypeAlias`, `match-case`, and shorthand for
Union types (`X | Y` instead of `Union[X, Y]` that require Python 3.10,
as flagged by #1143. Full
list of features added to 3.10 listed here:
https://docs.python.org/3/whatsnew/3.10.html

We're just going to be consistent for all extensions (even the ones that
don't use the 3.10 libraries).

I'm also going to re-publish and build the libraries (and includes this
in the release notes!)

---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1146).
* #1147
* __->__ #1146
@rossdanlm rossdanlm mentioned this issue Feb 7, 2024
Closed
rossdanlm pushed a commit that referenced this issue Feb 7, 2024
Changing all pyproject requires-python to 3.10
bee4f5c 
We have some libraries like `TypeAlias` that require Python 3.10, as flagged by #1143

We're just going to be consistent for all extensions (even the ones that don't use the 3.10 libraries).

I'm also going to re-publish and build the libraries (and includes this in the release notes!)
@rossdanlm
Copy link
Contributor

rossdanlm commented Feb 7, 2024 •
edited
Loading

Hey Erdem, we updated the pyprojects to all require >=3.10 in #1146! Also made a note of this in our changelog (https://github.com/lastmile-ai/aiconfig/releases/tag/v1.1.20) and this is not fixed in v1.1.20 for the main python-aiconfig library!

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossdanlm rossdanlm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing all pyproject requires-python to 3.10 lastmile-ai/aiconfig
3 participants
@saqadri @erdemunal35 @rossdanlm