-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change exist method for gitignore #291
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same issue and this looks like a good fix
This would fix on new versions but maybe crash on older versions, i think you should check the RUBY_VERSION, because old ruby versions still use .exists? |
Any chance of this being merged soon? Have to work with a fork otherwise. Thanks :) |
A merge would be quite nice |
I think this should already be merged, I almost wanted to create a new PR for the same Issue, can someone please merge this PR thanks :) |
The "exist?" method is also valid for old Ruby versions. The repository is using it in some files. cc @laserlemon. |
I believe the new alternative in 7+ is Pathname.new(path_name).exist? |
This was fixed in #294 so this PR can be closed. |
-Fix typo in the ignore_configuration method
This pull request fixes a typo in the
ignore_configuration
method of the project's codebase. The current implementation usesFile.exists?
to check if a.gitignore
file exists, which should be replaced withFile.exist?
for consistency with Ruby's standard library.I have tested this change on my local machine and confirmed that it resolves the issue.