-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add travis:encrypt command #140
Conversation
private | ||
|
||
def command | ||
%(travis encrypt #{travis_options} --split "#{vars}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does --split
do? Should it be the default even though it isn't in the travis
CLI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's pass our ENV variables as Travis accepts by default. I believe that's space separated. Unless there's an issue with that approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the approach I started with and ran into issues with encrypt throwing exceptions because the data to be encrypted was too large. We have a lot of env vars.
This looks really good, thank you! 👏 I've been looking forward to this ability for a while now. I left some comments for us to discuss. |
I'll sync on this today. |
Instead of documenting all of the various |
Apparently old versions of rails require thor 0.14.x. The feature I'm using to pass unknown options was only added in 0.17.0. Do we really want to support any version of rails older than 3.2? |
The travis guys have taken things in a different direction with their new env var implementation. In lieu of this functionality, I've added a simple 'print' command to spit out a figaro environment's variables. I can then add them to .travis.yml, the website, or with |
I took a pass at implementing the feature discussed in #8.
I exposed the
--add
and--override
options to allow the end user to control edits to .travis.yml.