add epsilon to sum(pvalue) upperbound (apache#16211)

larroy · Sep 28, 2019 · 1e50844 · 1e50844
1 parent ac7d4d8
commit 1e50844
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/operator/numpy/random/np_multinomial_op.cu b/src/operator/numpy/random/np_multinomial_op.cu
@@ -35,7 +35,7 @@ void CheckPvalGPU(DType* input, int prob_length) {
   DType sum = DType(0.0);
   for (int i = 0; i < prob_length; ++i) {
     sum += pvals_[i];
-    CHECK(sum <= DType(1.0))
+    CHECK(sum <= DType(1.0 + 1e-12))
       << "sum(pvals[:-1]) > 1.0";
   }
 }

diff --git a/src/operator/numpy/random/np_multinomial_op.h b/src/operator/numpy/random/np_multinomial_op.h
@@ -107,7 +107,7 @@ void CheckPval(DType* input, int prob_length) {
   DType sum = DType(0.0);
   for (int i = 0; i < prob_length; ++i) {
     sum += input[i];
-    CHECK_LE(sum, 1.0)
+    CHECK_LE(sum, 1.0 + 1e-12)
       << "sum(pvals[:-1]) > 1.0";
   }
 }
@@ -178,7 +178,7 @@ void NumpyMultinomialForward(const nnvm::NodeAttrs& attrs,
         sum += param.pvals.value()[i];
         // copy the tuple to data for later kernel usage
         pvals_[i] = param.pvals.value()[i];
-        CHECK_LE(sum, 1.0)
+        CHECK_LE(sum, 1.0 + 1e-12)
           << "sum(pvals[:-1]) > 1.0";
     }
     Kernel<multinomial_kernel, xpu>::Launch(