Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteConfig: Refactoring #176

Merged
merged 37 commits into from
Nov 23, 2022
Merged

RemoteConfig: Refactoring #176

merged 37 commits into from
Nov 23, 2022

Conversation

rznccc
Copy link
Contributor

@rznccc rznccc commented Nov 20, 2022

Hello!

  1. In case of Firebase CPP SDK >= 8.0.0, there was no control of futures returned from SDK code. So the correctness was not guaranteed.
  2. In case of Firebase CPP SDK >= 8.0.0, no need to give up if Google Play Services is not available. They could be updating, for example, SDK defines a set of reasons and supports its API anyway. So let it decide.
  3. Initial 500 ms delay has been removed from the initialization workflow: QTimer::singleShot(500 -> 0, ...).
  4. Added new property fetching.
  5. Added new signals googlePlayServicesError and futuresError.
  6. Pooling future's status on timer is not an elegant and efficient solution, I used callbacks.
  7. Support of Firebase CPP SDK < 8.0.0 has been kept.
  8. Backward compatibility of QtFirebase API has been kept.

@larpon larpon merged commit 4fde4fd into larpon:master Nov 23, 2022
@larpon
Copy link
Owner

larpon commented Nov 23, 2022

Very nice, thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants