Fix compilation on arm64 with analytics module #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that CLang on 64 bit arm is a ltitle bit nitpicking about types. Using good old `static_cast` helps.
|
Hi @MasterMind2k - I'm glad to see it's fixable - do you know if this is a general Clang thing or only a Clang thing for arm64-v8a architecture? Before I pull this in - I have to make sure changes doesn't break on other platforms, architectures and builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed issue when compiling QtFirebase with Analytics module.
Problem is with typing. With new platform, it seems compiler is unable to distinguish between
intandint64. Somehow :S. Maybe this is a Firebase bug after all?Related to #102.