-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with dev version of purrr #181
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 97.34% 98.70% +1.35%
==========================================
Files 38 38
Lines 1694 1695 +1
==========================================
+ Hits 1649 1673 +24
+ Misses 45 22 -23
|
The checks failed with R 3.6 on Windows but it could be due to the fact that the remotes version of purrr is not available. We need to re-check once the Remotes filed removed from DESCRIPTION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! once this is merged, i'll work on gtsummary too
Thanks. Let me remove the Remotes from the DESCRIPTION, re-run all checks and then merge. We may submit a new version on CRAN just after, what do you think? |
I looked in the purrr code and it seems to be a soft deprecation, meaning that warnings only appear in dev environments. So I don't there is any rush to release before their purrr 1.0 release |
It could be a problem for |
See tidyverse/purrr#969