Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy_multgee Incorrectly Defines Values in y.levels for Nominal Logistic Regression #260

Closed
jackmwolf opened this issue Jul 25, 2024 · 1 comment

Comments

@jackmwolf
Copy link
Contributor

tidy_multgee defines the variable y.levels, which, I believe, are intended to correspond to the levels of the response associated with each covariate. However, these levels are currently defined by taking factor levels (2, 3, ..., J). However, multgee::nomLORgee is parameterized such that factor level J is the reference group and covariates are given for the odds of levels (1, 2, ... J-1) versus the reference group (see the fitted marginal baseline category logit model in ?nomLORgee). Therefore, y.levels should correspond to the first J-1 levels of the factor, and not the last J-1 levels.

@larmarange
Copy link
Owner

Thank you for having spotting it and thanks for the PR. I'm currently traveling but will look at it in the following weeks.

larmarange added a commit to jackmwolf/broom.helpers that referenced this issue Jul 27, 2024
larmarange added a commit that referenced this issue Jul 27, 2024
Fix `tidy_multgee`'s `y.levels` (Issue #260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants