Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ForestToParseTree cache when ambiguity='resolve' #1433

Merged

Conversation

chanicpanic
Copy link
Contributor

Fixes #1283.

@erezsh
Copy link
Member

erezsh commented Jun 28, 2024

Lgtm.

I think maybe it's a good idea to add a comment explaining that caching is disabled because of the tree construction, or mention the issue number? Because it's not an obvious connection imho.

@chanicpanic
Copy link
Contributor Author

I think maybe it's a good idea to add a comment explaining that caching is disabled because of the tree construction, or mention the issue number? Because it's not an obvious connection imho.

Good idea, added.

@erezsh erezsh merged commit 7910ade into lark-parser:master Jun 29, 2024
9 checks passed
@erezsh
Copy link
Member

erezsh commented Jun 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Earley parser produces wrong parse Tree
2 participants