Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved typing around LALR and ParserState #1343

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Improved typing around LALR and ParserState #1343

merged 4 commits into from
Oct 2, 2023

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Sep 23, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Patch coverage: 97.87% and project coverage change: +0.07% 🎉

Comparison is base (c2e44ea) 89.23% compared to head (ac4e7a7) 89.31%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   89.23%   89.31%   +0.07%     
==========================================
  Files          51       52       +1     
  Lines        7591     7653      +62     
==========================================
+ Hits         6774     6835      +61     
- Misses        817      818       +1     
Flag Coverage Δ
unittests 89.31% <97.87%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lark/tools/standalone.py 87.85% <ø> (-0.12%) ⬇️
lark/parsers/grammar_analysis.py 93.65% <95.65%> (-0.10%) ⬇️
lark/parsers/lalr_parser_state.py 97.36% <97.36%> (ø)
lark/parsers/lalr_analysis.py 98.67% <97.61%> (+0.10%) ⬆️
lark/common.py 98.03% <100.00%> (+0.16%) ⬆️
lark/exceptions.py 90.41% <100.00%> (ø)
lark/grammar.py 96.15% <100.00%> (+0.32%) ⬆️
lark/lexer.py 91.05% <100.00%> (ø)
lark/load_grammar.py 92.61% <100.00%> (+<0.01%) ⬆️
lark/parser_frontends.py 95.90% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erezsh erezsh requested a review from MegaIng September 23, 2023 20:55
@erezsh erezsh merged commit ba5ae31 into master Oct 2, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants