Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextualLexer now uses self.basic_lexer for easy extensibility (iss… #1342

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Sep 23, 2023

…ue #1329)

@erezsh erezsh requested a review from MegaIng September 23, 2023 12:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.02% ⚠️

Comparison is base (c2e44ea) 89.23% compared to head (d83ad87) 89.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   89.23%   89.22%   -0.02%     
==========================================
  Files          51       51              
  Lines        7591     7600       +9     
==========================================
+ Hits         6774     6781       +7     
- Misses        817      819       +2     
Flag Coverage Δ
unittests 89.22% <89.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lark/lexer.py 90.78% <89.47%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erezsh
Copy link
Member Author

erezsh commented Sep 23, 2023

@davidmcnabnz Can you confirm this PR solves your issue?

(you can inherit ContextualLexer and override its basic_lexer attribute)

lark/lexer.py Outdated Show resolved Hide resolved
@erezsh erezsh requested a review from MegaIng September 23, 2023 13:19
@davidmcnabnz
Copy link

Thanks for that @erezsh . Commits look good, and plug up the configurability gap well. I look forward to migrating my lexer/parser over to the new version.

@erezsh erezsh merged commit ef1a8e8 into master Oct 2, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants