Remove unused __path__ variable (also conflicts with internal Python use of __path__)
#1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezsh
changed the title
__path__ modification.__path__ variable (also conflicts with internal Python use of __path__)
|
Sorry, accidentally broke this PR. But your commit has been accepted into master. Thanks! |
oraluben
added a commit
to alibaba/code-data-share-for-python
that referenced
this pull request
Oct 12, 2023
Summary: Do no cache unknown packages when `__path__` is unexpected. Follow up of #43. Test Plan: All tests Reviewed-by: - Issue: (related) lark-parser/lark#1338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__path__of a package is treated as iterable, whose elements are search paths of submodules.The assignment here seems to not have any effect and could cause trouble during the importing. It could be
[os.path.dirname(__file__)], but that's still the default value of the value.https://docs.python.org/3/reference/import.html#module-path