Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error message when using Lark.save() when parser!='lalr' #1328

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Aug 23, 2023

Addresses an oversight raised in issues #1323 and #788

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02% ⚠️

Comparison is base (656334c) 89.22% compared to head (ae6f43a) 89.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   89.22%   89.21%   -0.02%     
==========================================
  Files          51       51              
  Lines        7595     7597       +2     
==========================================
+ Hits         6777     6778       +1     
- Misses        818      819       +1     
Flag Coverage Δ
unittests 89.21% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lark/lark.py 85.62% <50.00%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erezsh erezsh merged commit fbe6f4c into master Aug 23, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants