Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments for PR #1152 #1191

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Adjustments for PR #1152 #1191

merged 6 commits into from
Sep 16, 2022

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Sep 15, 2022

  • utils.py no longer violates the limits of its knowledge
  • pickle is not limited to BytesIO

@erezsh erezsh mentioned this pull request Sep 15, 2022
Closed
@erezsh erezsh requested a review from MegaIng September 16, 2022 06:10
MegaIng
MegaIng reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to do a detailed review right now or in the next week. Nothing springs to my eyes on a quick glance.

@erezsh
Copy link
Member Author

erezsh commented Sep 16, 2022

That's fine, just wanted to give you a chance to review.

@erezsh erezsh merged commit f009312 into master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaIng MegaIng MegaIng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erezsh @MegaIng @henryiii