Vite watches the `vendor` folder

[stebogit]

• Laravel Vite Plugin Version: 0.6.1
• Laravel Version: 9.31.0
• Node Version: 16.17.1
• NPM Version: 8.15.0
• Host operating system: Linux (Homestead, Ubuntu 18.04.5 LTS)
• Web Browser & Version: -
• Running in Sail / Docker: No

Description:

Just installed Breeze (php artisan breeze:install) and tried to serve the assets (npm run dev) and I got this error, suggesting vite is watching the vendor folder (which I assume should be ignored, by default):

The command npm run build works fine anyway.

Steps To Reproduce:

This is my config, I tried to even defining a more restrictive refresh path:

export default defineConfig({
    plugins: [
        laravel({
            input: [
                'resources/css/app.css',
                'resources/js/app.js',
            ],
            // none of these work
            // refresh: true,
            // refresh: false,
            refresh: [
                'resources/**',
            ],
        }),
    ],
});

[timacdonald]

Hi @stebogit,

I'm unable to reproduce this with a fresh Laravel installation. I can only get Vite to watch the vendor directory if I explicitly configure it to watch it.

Can you create a reproduction repository for this and we can re-open the issue?

laravel new bug-report --github="--public"

[michaelk83]

There are multiple users affected by this, see laravel/framework#46928 . But you need to have enough files in vendor/ or a low enough watches limit to trigger the error. The latter would depend on your system configuration. More recent linux system may have a higher limit set by default.
https://stackoverflow.com/a/67171846/15047974
https://stackoverflow.com/a/55543310/15047974

In any case, even if the watches limit is high enough, watching thousands of irrelevant files can be slow, so the vendor/ folder (and storage/, I guess) should not be listened to by default. I don't know if this should be addressed in the plugin or framework, but I've found this issue here, so am linking to the discussion above.

[timacdonald]

I'm not against the idea of ignoring some directories by default. As Vite ignores node_modules by default I think it could make sense for us to ignore vendor by default, along with some other directories(?).

The main problem I see is the globing patterns, such as **/vendor/**, would ignore any directory named vendor. That is unfortunate as Laravel publishes assets to the public/vendor directory.

That being said, as they are "vendor" files there is potential that it also makes sense to ignore them by default as you likely are not changing them inline.

[michaelk83]

If **/vendor/** is not optimal, I think /vendor/** should also work.
https://vitejs.dev/guide/features#glob-import-caveats

Or:

'**/vendor/**',
'!/public/vendor/**'