Skip to content

Support symfony/yaml version 5 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Support symfony/yaml version 5 #43

merged 1 commit into from
Mar 19, 2020

Conversation

viezel
Copy link
Contributor

@viezel viezel commented Mar 19, 2020

Since most Laravel packages are locking min req of Symfony packages to v5, then we need to be able to use symfony/yaml v5.

As seen below, we cannot require Vapor-Cli package due to this.

$ composer require laravel/vapor-cli --dev
Using version ^1.6 for laravel/vapor-cli
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: remove symfony/dependency-injection v5.0.5
    - Conclusion: don't install symfony/dependency-injection v5.0.5
    - symfony/yaml 4.2.x-dev conflicts with symfony/dependency-injection[v5.0.5].
    - symfony/yaml 4.3.x-dev conflicts with symfony/dependency-injection[v5.0.5].
    - symfony/yaml v4.2.0 conflicts with symfony/dependency-injection[v5.0.5].
    ...

See https://github.com/symfony/dependency-injection/blob/master/composer.json#L41

@taylorotwell taylorotwell merged commit b3a79a2 into laravel:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants