Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide environment keys / Add EnvironmentHasExceededLimit solution #222

Merged

Conversation

luanfreitasdev
Copy link
Contributor

This Pull Request allows you to hide environment variables when they are executed by Lambda in more than 4kb in the deploy output. Validation is done by comparing the message returned in deploy.

A Solution has also been added for this case.

All keys are exposed from the text "String measured"

image

@luanfreitasdev
Copy link
Contributor Author

I was unable to reproduce the problem in my local environment. Did I forget something?

@joedixon
Copy link
Contributor

Thanks @luanfreitasdev - I'll take a look at this tomorrow. GH Actions have been having some issues today so hopefully that's the issue with the tests.

@taylorotwell taylorotwell marked this pull request as draft May 10, 2023 17:41
@joedixon
Copy link
Contributor

Screenshot 2023-05-11 at 15 30 33

@joedixon joedixon requested a review from nunomaduro May 11, 2023 18:34
@luanfreitasdev luanfreitasdev marked this pull request as ready for review May 12, 2023 12:19
@taylorotwell taylorotwell merged commit 77f86c2 into laravel:master May 12, 2023
@luanfreitasdev luanfreitasdev deleted the fix/deploy-showing-environment branch May 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants