Allow using custom ARM-based Docker images

[orkhanahmadov]

This PR allows using custom ARM-based Docker images.

We always pre-build vapor image with extras (like Imagick extension), push it to AWS ECR then use that ECR image for deployments in production.Dockerfile. Disallowing custom ARM images prevents doing this.

[nunomaduro]

Bugfix release 1.55.2 introduced a breaking change for everyone that uses custom Docker ARM images for deployments.

What do you mean by "introduced a breaking change", if we shipped ARM for docker yesterday? We still allow custom images if customers wish to build their own amd64 image. However, for arm64, that we shipped yesterday, we are developing internally some things that we wish to ship before we allow our customers to build custom ARM builds.

[orkhanahmadov]

@nunomaduro sorry the for confusion. When we started having issues on our deployments and when started investigating the issue, also looking into new ARM-based images, the latest available versions of the package were 1.55.1 and 1.55.2 they both disallowed using any custom images, which was a breaking change. Now I noticed 1.55.3 was released and it also allows x86 Docker images again.

But I think you can still consider this PR since it also allows using ARM-based custom Docker images too.

In our use case, we won't be using laravelphp/vapor:php82-arm as a deployment image, because we add more steps to it, which unnecessarily increases build time on every deployment. We always use our own AWS ECR pre-build image which uses laravelphp/vapor:php82-arm as a base.

[orkhanahmadov]

Just updated the PR title and description to better reflect the purpose of this PR.

[joedixon]

Is this relevant or should I open a support ticket?

Hey @aubreychiduku can you open a support ticket for this please as it's an unrelated issue.

[orkhanahmadov]

More context:

To build the base image for ARM I also noticed that the image requires a __VAPOR_RUNTIME argument. We pass it manually:

docker build -t vapor-base . --build-arg __VAPOR_RUNTIME=docker-arm

I mentioned this yesterday to Taylor's tweet with the ARM support announcement.

[joedixon]

Hey @orkhanahmadov we do plan to add support for custom images using the docker-arm runtime. However, we want to put some safeguards in place to prevent the accidental deployment of an Arm image to a Lambda running x86.

We would advise against pre-building your image until we have this update in place which should be in the coming days.

Closing this PR for now.

[pyr0hu]

@joedixon any updates on this one?

[imrodrigoalves]

@joedixon When should we expect this feature to be available?

[joedixon]

I'm going to give this another test, but assuming it all works as expected, I think we can get this merged now.