Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds env:passport command #206

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Adds env:passport command #206

merged 4 commits into from
Nov 28, 2022

Conversation

joedixon
Copy link
Contributor

This PR adds a command to add Passport keys to the customer's environment file. Passport keys are too large to be stored directly in the environment, so this command is to be used only in conjunction with encrypted environment files.

The command will:

  • Prompt the user to confirm they are using encrypted envs
  • Check the .env.[ENV] file exists
  • Check the Passport keys exist
  • Attempt to parse the .env.[ENV] file
  • Check Passport keys don't already exist
  • Append the keys to the .env.[ENV] file
  • Prompt the user to use env:encrypt and redeploy

Screenshot 2022-11-24 at 14 32 52

Screenshot 2022-11-24 at 14 32 08

@joedixon joedixon marked this pull request as draft November 24, 2022 14:37
@nunomaduro
Copy link
Member

Good job. Can you elaborate on this will work for people using passports environment variables on secrets this moment?

@joedixon
Copy link
Contributor Author

Good job. Can you elaborate on this will work for people using passports environment variables on secrets this moment?

Yes, if they're running Laravel 9 and using encrypted environment files, they can swap the passport keys from secrets to the env with this PR.

@joedixon joedixon marked this pull request as ready for review November 28, 2022 13:39
@taylorotwell
Copy link
Member

@joedixon

"You should only use this command if when"... looks like needs some fixing in the message?

@joedixon
Copy link
Contributor Author

joedixon commented Nov 28, 2022

@taylorotwell fixed in a subsequent commit (db61b44), but didn't update the screenshots

@taylorotwell taylorotwell merged commit 5a28bc8 into master Nov 28, 2022
@taylorotwell taylorotwell deleted the feat/env-passport-command branch November 28, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants