Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes 500 public assets limitation and makes files uploads concurrent #183

Merged
merged 3 commits into from
May 13, 2022

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented May 12, 2022

This pull request removes 400 public assets limitation and makes files uploads concurrent.

  • The 400 public assets limitation is removed by applying pagination - using 400 elements - when reaching Vapor API. So, when asking the Vapor API for the store/copy signed URL, we lazy paginate over each 400 elements.
  • Next, this pull request also contains code that makes files uploads concurrent, uploading streaming 10 files per S3 store object request.
  • Finally, this pull request also provides store / copying feedback in real-time on the console.

@nunomaduro nunomaduro marked this pull request as ready for review May 12, 2022 15:34
@nunomaduro nunomaduro merged commit fc201b3 into master May 13, 2022
@nunomaduro nunomaduro deleted the feat/improve-serve-assets branch May 13, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant