fix certificate deletion and vanity domain output

laravel · Feb 11, 2020 · 8acc858 · 8acc858
1 parent 287dbf6
commit 8acc858
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/Commands/CertDeleteCommand.php b/src/Commands/CertDeleteCommand.php
@@ -84,14 +84,14 @@ protected function determineCertificate()
      */
     protected function getCertificateForDomain(array $certificates, $domain)
     {
-        $certificateId = collect($certificates)->firstWhere(
+        $certificate = collect($certificates)->firstWhere(
             'domain', $domain
         );
 
-        if (! $certificateId) {
+        if (! $certificate) {
             Helpers::abort('You do not have any certificates matching the given criteria.');
         }
 
-        return $certificateId;
+        return $certificate['id'];
     }
 }
diff --git a/src/Commands/Output/DeploymentSuccess.php b/src/Commands/Output/DeploymentSuccess.php
@@ -27,15 +27,17 @@ public function render(Deployment $deployment, DateTimeInterface $startedAt)
             $this->displayTargetDomains($deployment);
         }
 
-        Helpers::line();
+        if ($deployment->vanityDomain()) {
+            Helpers::line();
 
-        Helpers::table([
-            '<comment>Deployment ID</comment>',
-            '<comment>Environment URL (Copied To Clipboard)</comment>'
-        ], [[
-            "<bright>{$deployment->id}</>",
-            "<bright>https://{$deployment->vanityDomain()}</>",
-        ]]);
+            Helpers::table([
+                '<comment>Deployment ID</comment>',
+                '<comment>Environment URL (Copied To Clipboard)</comment>'
+            ], [[
+                "<bright>{$deployment->id}</>",
+                "<bright>https://{$deployment->vanityDomain()}</>",
+            ]]);
+        }
     }
 
     /**