Specify Environment Dockerfile Path In Manifest (#178)

* Specify Environment Dockerfile Path In Manifest

* formatting

Co-authored-by: Damian Crisafulli <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 3 people

src/Docker.php

@@ -38,8 +38,8 @@ public static function build($path, $project, $environment, $cliBuildArgs)
      */
     public static function buildCommand($project, $environment, $cliBuildArgs, $manifestBuildArgs)
     {
-        return sprintf('docker build --pull --file=%s.Dockerfile --tag=%s %s.',
-            $environment,
+        return sprintf('docker build --pull --file=%s --tag=%s %s.',
+            Manifest::dockerfile($environment),
             Str::slug($project).':'.$environment,
             Collection::make($manifestBuildArgs)
                 ->merge(Collection::make($cliBuildArgs)

src/Manifest.php

@@ -55,6 +55,17 @@ public static function buildCommands($environment)
         return static::current()['environments'][$environment]['build'] ?? [];
     }
 
+    /**
+     * Get the Dockerfile for the given environment.
+     *
+     * @param  string  $environment
+     * @return string
+     */
+    public static function dockerfile($environment)
+    {
+        return static::current()['environments'][$environment]['dockerfile'] ?? "{$environment}.Dockerfile";
+    }
+
     /**
      * Get the Docker build arguments.
      *

src/Path.php

@@ -112,6 +112,6 @@ public static function vapor()
      */
     public static function dockerfile($environment)
     {
-        return getcwd().'/'.$environment.'.Dockerfile';
+        return getcwd().'/'.Manifest::dockerfile($environment);
     }
 }

tests/DockerTest.php

@@ -2,11 +2,26 @@
 
 namespace Laravel\VaporCli\Tests;
 
+use Illuminate\Container\Container;
 use Laravel\VaporCli\Docker;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Yaml\Yaml;
 
 class DockerTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        touch($testManifest = getcwd().'/test.vapor.yml');
+        Container::getInstance()->offsetSet('manifest', $testManifest);
+    }
+
+    protected function tearDown(): void
+    {
+        @unlink(Container::getInstance()->offsetGet('manifest'));
+        parent::tearDown();
+    }
+
     public function test_build_command_no_build_args()
     {
         $command = Docker::buildCommand('my-project', 'production', [], []);
@@ -41,4 +56,21 @@ public function test_build_command_cli_and_manifest_build_args()
             "--build-arg='FOO=BAR' --build-arg='FIZZ=BAZZ' --build-arg='BAR=FOO' .";
         $this->assertEquals($expectedCommand, $command);
     }
+
+    public function test_dockerfile_from_manifest()
+    {
+        file_put_contents(Container::getInstance()->offsetGet('manifest'), Yaml::dump([
+            'id'           => 1,
+            'name'         => 'Test',
+            'environments' => [
+                'production' => [
+                    'runtime'    => 'docker',
+                    'dockerfile' => 'docker/shared.Dockerfile',
+                ],
+            ],
+        ]));
+        $command = Docker::buildCommand('my-project', 'production', [], []);
+        $expectedCommand = 'docker build --pull --file=docker/shared.Dockerfile --tag=my-project:production .';
+        $this->assertEquals($expectedCommand, $command);
+    }
 }