Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Environment Dockerfile Path In Manifest #178

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

damiantw
Copy link
Contributor

@damiantw damiantw commented Apr 2, 2022

I've found the current convention for Dockerfile paths to be a papercut annoyance for Docker runtime Vapor projects with many environments.

As is, Dockerfiles must be stored in the project root, and chances are they will not be grouped together in an alphabetical directory listing due to the environment name serving as the filename prefix.

In addition, each environment must have its own Dockerfile. Often the Dockerfile contents for multiple environments end up being identical, or, things could be structured such that multiple environments could share a Dockerfile by taking advantage of unique Docker build argument values per environment.

This PR allows for specifying a custom Dockerfile path for each environment via a new optional dockerfile field in the Vapor manifest file.

This will allow developers to incorporate their preferred filename convention for Dockerfiles, store Dockerfiles in subdirectories, and share Dockerfiles between environments.

If the dockerfile field is not specified for an environment, the current {environment}.Dockerfile filename convention is preserved.

@taylorotwell taylorotwell merged commit 326ae4f into laravel:master Apr 2, 2022
@damiantw damiantw deleted the manifest-dockerfile branch April 2, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants