Specify Environment Dockerfile Path In Manifest #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found the current convention for Dockerfile paths to be a papercut annoyance for Docker runtime Vapor projects with many environments.
As is, Dockerfiles must be stored in the project root, and chances are they will not be grouped together in an alphabetical directory listing due to the environment name serving as the filename prefix.
In addition, each environment must have its own Dockerfile. Often the Dockerfile contents for multiple environments end up being identical, or, things could be structured such that multiple environments could share a Dockerfile by taking advantage of unique Docker build argument values per environment.
This PR allows for specifying a custom Dockerfile path for each environment via a new optional
dockerfile
field in the Vapor manifest file.This will allow developers to incorporate their preferred filename convention for Dockerfiles, store Dockerfiles in subdirectories, and share Dockerfiles between environments.
If the
dockerfile
field is not specified for an environment, the current{environment}.Dockerfile
filename convention is preserved.