Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved config to file #68

Closed
wants to merge 1 commit into from
Closed

Moved config to file #68

wants to merge 1 commit into from

Conversation

finagin
Copy link

@finagin finagin commented Mar 28, 2019

Fix #63 if append 'usePcntl' => false, to tinker.config section

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@finagin
Copy link
Author

finagin commented Mar 28, 2019

@taylorotwell, this change will allow you to fine tinker and resolve the issue #63

@driesvints
Copy link
Member

@finagin as noted in the issue disabling jit isn't a solution but a bandaid. The problem with Homebrew needs to be fixed.

@finagin
Copy link
Author

finagin commented Mar 29, 2019

@driesvints, however, it would be nice to be able to fine-tune the psy/psysh.

@bobthecow
Copy link
Contributor

You can already fine-tune the PsySH configuration via a local .psysh.php config file in your project, or a user-level config at ~/.config/psysh/config.php. It's probably not necessary to add yet another way to configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working after upgrade to PHP 7.3.0
4 participants