Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Remove unused orchestra/testbench deps #166

Merged
merged 3 commits into from
Aug 15, 2023
Merged

[2.x] Remove unused orchestra/testbench deps #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
035d7f2
[2.x] Remove unused `orchestra/testbench` deps
crynobone Aug 15, 2023
06b2996
wip
crynobone Aug 15, 2023
169d65b
Apply fixes from StyleCI
StyleCIBot Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
},
"require-dev": {
"mockery/mockery": "~1.3.3|^1.4.2",
"orchestra/testbench": "^4.0|^5.0|^6.0|^6.0|^7.0|^8.0",
"phpstan/phpstan": "^1.10",
"phpunit/phpunit": "^8.5.8|^9.3.3"
},
Expand Down
1 change: 1 addition & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ parameters:

ignoreErrors:
- "#Unsafe usage of new static\\(\\)#"
- "#Class Illuminate\\\\Foundation\\\\Application not found.#"
- "#Class Laravel\\\\Lumen\\\\Application not found.#"
2 changes: 1 addition & 1 deletion src/TinkerServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function boot()
$source = realpath($raw = __DIR__.'/../config/tinker.php') ?: $raw;

if ($this->app instanceof LaravelApplication && $this->app->runningInConsole()) {
$this->publishes([$source => config_path('tinker.php')]);
$this->publishes([$source => $this->app->configPath('tinker.php')]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface available in Laravel Framework 6: https://github.com/laravel/framework/blob/10.x/src/Illuminate/Contracts/Foundation/Application.php#L88-L93

} elseif ($this->app instanceof LumenApplication) {
$this->app->configure('tinker');
}
Expand Down