[4.0] Handle Google responses excluding 'name' #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had a Google login callback in production throw an exception because the 'name' JSON key was missing in the payload. Generally this would be a full response body:
But for incomplete (or service migrated?) accounts Google may exclude some keys. I can't find complete documentation covering how this OAuth2 scope is supposed to behave. They only offer a live-fetch form: https://developers.google.com/apis-explorer/#search/userinfo/m/oauth2/v2/oauth2.userinfo.v2.me.get
Socialite's 3.0 branch already handles this field as optional: https://github.com/laravel/socialite/pull/319/files#diff-2adaa1ef0c311c4b988908f120ea7557R84