Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Check if channel variable isn't null when passed as a filter on channels() method in ArrayChannelManager #292

Merged
merged 2 commits into from
Dec 27, 2024
Merged

[1.x] Check if channel variable isn't null when passed as a filter on channels() method in ArrayChannelManager #292

merged 2 commits into from
Dec 27, 2024
+14 −1

Conversation

kirills-morozovs
Copy link
Contributor

Fixes issue #291

@taylorotwell
Copy link
Member

Tests are failing. @joedixon are you able to help?

@taylorotwell taylorotwell marked this pull request as draft December 27, 2024 20:33
@joedixon joedixon changed the title Check if channel variable isn't null when passed as a filter on channels() method in ArrayChannelManager [1.x] Check if channel variable isn't null when passed as a filter on channels() method in ArrayChannelManager Dec 27, 2024
@joedixon joedixon marked this pull request as ready for review December 27, 2024 21:02
@taylorotwell taylorotwell merged commit a058259 into laravel:main Dec 27, 2024
11 checks passed
@crynobone crynobone mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joedixon joedixon joedixon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirills-morozovs @taylorotwell @joedixon