Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Boxes With All Supported Colors #47

Merged

Conversation

devajmeireles
Copy link
Contributor

Fixes: #45

Output:

CleanShot 2023-08-09 at 2 04 08

@devajmeireles devajmeireles changed the title Draw Boxes With All Supported Colors [FIX] Draw Boxes With All Supported Colors Aug 9, 2023
@jessarcher
Copy link
Member

Thanks! It would be nice if this supported the rest of the syntax, like foreground colors and other text formatting like bold, italic, etc.

I wonder whether Symfony has any methods we can call to strip the text (e.g. for the non-ANSI output version) or whether we can look at how they're processing the text.

@jessarcher jessarcher marked this pull request as draft August 9, 2023 22:46
@jessarcher jessarcher added the bug label Aug 9, 2023
@jessarcher jessarcher self-requested a review August 9, 2023 22:46
@driesvints driesvints changed the title [FIX] Draw Boxes With All Supported Colors Draw Boxes With All Supported Colors Aug 14, 2023
@jessarcher jessarcher force-pushed the draw-boxes-with-all-supported-colors branch from 67f9fff to 8f6f065 Compare August 15, 2023 02:28
@jessarcher
Copy link
Member

I've just updated the regex to handle more Symfony formatting tags (like bold, underscores, etc.) as well as handling tags with multiple options (e.g. <fg=blue;bg=red> and <options=bold,underscore></>).

@jessarcher jessarcher marked this pull request as ready for review August 15, 2023 02:28
@taylorotwell taylorotwell merged commit fc58be6 into laravel:main Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of colors makes the right border position incorrect
3 participants