Fix textarea helper method signature. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature previously (incorrectly) typed the `$validate` parameter as a nullable Closure. The upstream signature declares the parameter as mixed, same as the other prompt types.
samrap
force-pushed
the
fix-textarea-helper-signature
branch
from
d21fcc2
to
98a1a27
Compare
jessarcher
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
textareahelper function currently has the wrong signature.The signature previously (incorrectly) typed the
$validateparameter as a nullableClosure. The upstream signature declares the parameter as a nullablemixed, same as the other prompt types.What does this fix? It allows us to use all of the types of validation for textarea prompts (using the helpers).
I don't believe we need tests since we are just piping the data through to an object which supports this value.