-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transformation support #156
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I think that |
@emenkens does FormBuilder need to be updated? Please mark as ready for review when the requested changes have been made. |
@taylorotwell it does indeed! Thank you @macocci7 for pointing that out. I've updated it now. |
I thought it would be nice to be able to make changes to input before it gets validated.
Problem
Suppose you want to trim user input before it's validated. We start off with a basic prompt to ask for a username:
If I enter
string(8) " "
(8 spaces), that's a totally valid username. This could of course be solved with validation, so let's add a validation rule to make sure that the username, when trimmed, is at least 4 characters:And enter
string(8) " ssss "
(2 spaces, and the letters
4 times, followed by 2 more spaces). The validation logic above trims the string and agrees thatstring(4) "ssss"
is a valid username. However, that's not the input we entered...The
trim
function was called inside the validation logic, which means the value of$username
will still bestring(8) " ssss "
. This could be resolved with more advanced validation logic, like not allowing a string to start and end with a space etc., but this can become unmanageable pretty fast.We could of course wrap all of the code above in a
trim()
:but now I have repeated myself and have to remember to change the code every time the validation logic changes. This can be tedious when working with large form sets, especially if there are multiple developers working on the same codebase.
Solution
In this PR, I have added a
transform
option, which accepts aClosure
and can be used like this:This will alter the value before validation takes place, which means I don't need to repeat myself, and I know for sure that the value that is assigned to
$username
is the same value that was being validated.This could be super useful not only for trimming strings, but also to filter out other kinds of unwanted characters, like spaces in a phone number or hyphens in a UUID. It can also be used with the
Str
helpers:All input types are supported and I've added tests for each type. Let me know what you think!
Thank you