Allow re-rendering during progress callback #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows developers to update the
progress
label and hint at any point during their callback by calling therender
method on theProgress
class. Previously, a re-render only occurred between each step, so updating the label or hint to reflect what was about to happen was not possible.Additional render calls on each iteration can add up to a meaningful delay over a lot of iterations, so I don't think it makes sense to always force a re-render on every call to the
label
orhint
methods.Fixes #153