Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Add method to fix octane route caching. #659

Merged
merged 2 commits into from
Mar 13, 2023
Merged

[1.x] Add method to fix octane route caching. #659

merged 2 commits into from
Mar 13, 2023

Conversation

CharlesBilbo
Copy link
Contributor

@CharlesBilbo CharlesBilbo commented Mar 13, 2023 •
edited
Loading

This PR is a required dep to this pr in the main repo.

this method is required to get octane specific routes for caching.

laravel/framework#46448

@CharlesBilbo CharlesBilbo changed the title add getRoutes to the providesRouting Trait add getRoutes to the providesRouting to fix route caching. Mar 13, 2023
@CharlesBilbo CharlesBilbo mentioned this pull request Mar 13, 2023
Closed
@CharlesBilbo CharlesBilbo marked this pull request as draft March 13, 2023 17:11
@CharlesBilbo CharlesBilbo changed the title add getRoutes to the providesRouting to fix route caching. [1.x] Add method to fix octane route caching. Mar 13, 2023
@CharlesBilbo CharlesBilbo marked this pull request as ready for review March 13, 2023 17:17
@taylorotwell taylorotwell merged commit 8bf55ba into laravel:1.x Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesBilbo @taylorotwell