[5.6] Remove unnecessary package

[freekmurze]

The thanks package is not needed to develop kickass Laravel apps.

[michaeldyrynda]

A-class shit stirring 👍

[freekmurze]

@michaeldyrynda should have titled this PR "Thanks, but no thanks"

[sixlive]

100% for the removal of this

[nunomaduro]

This is the only thing I remove on a new Laravel app. I am in favor of this removal. 👍

[introwit]

php artisan merge:asap

[dikiaap]

The accuracy of GitHub Trending in PHP will be back.

[m1guelpf]

Yes please!

[GuidoHendriks]

I would say it’s not bad to encourage thanking people who saved you tons of time. Takes about 2 seconds to remove it if you don’t want it on your own project. Such a silly thing to complain about. 👎🏻

[crynobone]

It's a malware to be honest.

[frankdejonge]

@freekmurze what's the reason for the removal? It seems to have a rather positive effect on the laravel stars (and mine). It's even more beneficial for laravel than it is for symfony:

http://www.timqian.com/star-history/#thephpleague/flysystem&symfony/symfony&laravel/laravel

[frankdejonge]

I also see people talking about accuracy. It seems MANY people are actively developing using laravel and that shows. So I'm not sure why this accuracy is at stake.

[freekmurze]

@frankdejonge This tool makes it even harder for not well known package creators to get noticed. It only seems to benefit already well known packages / tools. Take a look at trending php packages page on GitHub. (screenshot from a few days ago).

Kinda crazy that the thanks package itself is one of the most starred packages.

Don't get me wrong, Symfony and all others which benefit from the tool deserve all the respect they can get, but semi-automating starring is not the way to get that (imho).

[frankdejonge]

@freekmurze isn't that simply a correction though? That screenshot is nothing like the current status, where laravel is at the top and a far lesser known but recently popular package (php-school/cli-menu) is second.

[taylorotwell]

@frankdejonge My main issue with the tool is the recursive nature of it. For example if a Laravel developer uses composer thanks, the Symfony organization actually gets more stars than the Laravel organization, even though we only use 8 Symfony packages and well over 20 Illuminate packages.

However, as long was Symfony promoting it I feel like I'm between a rock and a hard place because if Symfony is the only one benefiting I don't want to face the stupid comments of "oh wow Laravel is dying look at the stars Symfony is getting omg" ...

I know that Symfony has now removed "thanks" from the default Flex install because of push back from the Symfony community. So, that could be why their packages aren't trending quite so high anymore and could be reason for us to follow suit in removing it from the default install.

[freekmurze]

I don't want to face the stupid comments of "oh wow Laravel is dying look at the stars Symfony is getting omg" ...

It's an accident waiting to happen really: http://git-awards.com/users?language=php. Next week you won't find me on Twitter.

@frankdejonge not so long ago this page contained some cool new stuff: https://github.com/trending/php?since=monthly

I'm pretty sure the creators of the thanks package meant no harm, but in it's current state the package doesn't seem beneficial besides the already well known creators.

[javiereguiluz]

Sorry to interrupt this discussion ... I just wanted to note that even Laravel requires 8 Symfony components, it requires another 2 components in require-dev and a composer create-project --prefer-dist laravel/laravel command ends up installing 13 components because of the cross dependencies.

[lukylook]

@taylorotwell you dont need to work for starts on github this is not the point, and you know that.
laravel is great with star on github and without this bullshit.
and need keep doing even greater ...
Thank you (with or without) :)

please remove this package, perosnaly it make me feel stupid to show it on my projects.

[ankurk91]

Read this
https://github.com/symfony/thanks/blob/9474ce305253c2f0bc20322ff8e9973cf25c9a94/src/Command/ThanksCommand.php#L32-L35

[GrahamCampbell]

Surely the wrong laravel repo is getting starred for illuminate packages?

[crynobone]

Surely the wrong laravel repo is getting starred for illuminate packages?

And https://github.com/symfony/polyfill-php70 contributes to symfony/symfony? How is that not a malware 😁