Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Add Non Latin Character Support For Str::slug #6204

Closed
wants to merge 2 commits into from
Closed

[4.2] Add Non Latin Character Support For Str::slug #6204

wants to merge 2 commits into from

Conversation

reshadman
Copy link

Add support for UTF-8 encoded slugging. In case of slugging persian characters (like آ, ب, ژ) converting encoding to ASCII causes an empty string.

// سلام-دنیا
Str::lightSlug('سلام دنیا'); 

//empty string 
Str::slug('سلام دنیا');

@reshadman reshadman changed the title Add non lating charecter support for Str::slug Add non latin character support for Str::slug Oct 23, 2014
@GrahamCampbell GrahamCampbell changed the title Add non latin character support for Str::slug [4.2] Add Non Latin Character Support For Str::slug Oct 26, 2014
@GrahamCampbell
Copy link
Member

The tests are failing @bigsinoos. Also, this is best sent to 5.0 because of the change in the method signature. Also, you'll need to fix the docblock for the extra method you added.

@lucasmichot
Copy link
Contributor

This has been told many times in PR, but maybe replacing the Str helpers with https://github.com/danielstjules/Stringy would be a good idea

@GrahamCampbell
Copy link
Member

@lucasmichot, @taylorotwell already rejected my pull to move us over to stringy.

@taylorotwell Would you reconsider for laravel 5.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants