[12.x] Move duplicated logic to separate method to be reusable

[shaedrich]

Follow-up to #57556 (comment)

✅ Improves readability by making the methods more compact without the "internal logic" in each of them
✅ Improves maintainability by having a single source of truth/failure
✅ Makes adapting this in new methods quite easy

[AndrewMast]

Hey, just pointing out, your code introduces using Str::lower onto the replace value where the original code does not. I don't know if it actually changes anything, but thought I'd mention it.

[shaedrich]

@AndrewMast Thanks for the reminder 👍🏻 Yeah, I thought, I'd make it more robust but maybe, it's too much for one PR and should be done separately 🤔

[shaedrich]

Technically, this could also be used for

• replaceMissingWith()

  • $this->replaceKeepCase(
      $message,
      ['values' => $this->getAttributeList($parameters)],
      ['values' => ' / '],
    )

• replaceIn()

  • $this->replaceKeepCase(
      $message,
      ['values' => $this->getAttributeList($parameters)],
      ['values' => ', '],
    )

• replacePresentWith()
• replaceRequiredWith()
• replaceRequiredUnless()
• replaceProhibits()

when modifying this:

- function replaceKeepCase($message, $mapping)
+ function replaceKeepCase($message, $mapping, $wordSeparators = [])
{
-   $fn = [Str::lower(...), Str::upper(...), Str::ucfirst(...)];
+   $fn = [
+       Str::lower(...),
+       Str::upper(...),
+       //fn (string $placeholder, ?string $parameter = null) => ucwords($parameter ?? $placeholder, $parameter !== null ? ($wordSeparators[$placeholder] ?? ' ') : ' '),
+       fn (string $placeholder, ?string $parameter = null) => $parameter !== null && array_key_exists($placeholder, $wordSeparators)
+           ? ucwords($parameter ?? $placeholder, $wordSeparators[$placeholder])
+           : ucfirst($parameter ?? $placeholder),
+   ];
    $cases = array_reduce(
        array_keys($mapping),
-       fn (array $carry, string $placeholder) => [...$carry, ...array_map(fn (callable $fn) => ':'.$fn($placeholder), $fn)],
+       fn (array $carry, string $placeholder) => [...$carry, ...array_map(fn (callable $fn) => ':' . $fn($placeholder), $fn)],
        [],
    );
    $replacements = array_reduce(
-       array_values($mapping),
+       array_keys($mapping),
-       fn (array $carry, string $parameter) => [...$carry, ...array_map(fn (callable $fn) => $fn($parameter), $fn)],
+       fn (array $carry, string $placeholder) => [...$carry, ...array_map(fn (callable $fn) => $fn($placeholder, $mapping[$placeholder]), $fn)],
        [],
    );

    return str_replace($cases, $replacements, $message);
}