-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[12.x] Add NamedScope attribute #54450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6915a93
Add NamedScope attribute
shaedrich 1b11b31
StyleCI
shaedrich df67443
Make Model::getAttributedNamedScope() protected
shaedrich 19590d2
wip
crynobone d6fc922
wip
crynobone 6d5aa00
wip
crynobone 3d3b2cd
wip
crynobone 9f6db62
wip
crynobone 90de5cf
fix(database): ✏ Fix typo
shaedrich 19f4804
refactor(database): :truck: Rename attribute class
shaedrich 799451a
refactor(database): :white_check_mark: Simplify test
shaedrich ded61f4
refactor(database): :recycle: Simplify named local scope attribute ch…
shaedrich ab19b5e
fix(database): :bug: Make attributed named scope statically callable
shaedrich 83a21e4
style(database): :rotating_light: StyleCI
shaedrich 50dbb5a
style(database): :rotating_light: StyleCI
shaedrich eb4fc57
formatting
taylorotwell 2c44cd5
add files
taylorotwell 1cf779d
fix tests
taylorotwell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
src/Illuminate/Database/Eloquent/Attributes/NamedScope.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Database\Eloquent\Attributes; | ||
|
|
||
| use Attribute; | ||
|
|
||
| #[Attribute(Attribute::TARGET_METHOD)] | ||
| class NamedScoped | ||
| { | ||
| /** | ||
| * Create a new attribute instance. | ||
| * | ||
| * @param array|string $classes | ||
| * @return void | ||
| */ | ||
| public function __construct() | ||
| { | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need to check if
$methodreturnfalsefor incorrect usage such asabstractmethod orpublic function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In lines 1638 – 1640, we test if the method exists—isn't that enough, meaning do we care about how the method is implemented?