[10.x] Set IP:PORT as key to $requestsPool
on ServeCommand
#46740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with the issue #46726.
The previous PR only avoid the error when the process output try to write on a port previously closed by a different request.
Currently the
$requestsPool
array onIlluminate\Foundation\Console\ServeCommand
is handling the requests using only the port, but requests can reuse the same port, then different request from different clients (IP) would be handled as same request.This PR adds the IP as part of
$requestsPool
.This PR also factorizes the
handleProcessOutput
method to avoid too much complexity in a single function moving every possible output to a own method (the code wasn't changed on every output type, only was moved to a new method).